Skip to content

🐛 Unified the redis_namespace for LRT ⚠️🚨 #8450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 6, 2025
Merged

🐛 Unified the redis_namespace for LRT ⚠️🚨 #8450

merged 6 commits into from
Oct 6, 2025

Conversation

@GitHK
Copy link
Contributor

@GitHK GitHK commented Oct 3, 2025 •
edited
Loading

What do these changes do?

Very subtle issue, due to a wrong test the functionality was working sometimes. The test would always pass but because it was wrong.

Some LrtNamespaces can contain uuids which usually contain lower case letters. That's why this was not detecetd. (eg, a sidecar SIMCORE-SERVICE-DYNAMIC-SIDECAR-1756455678_1A189515-6961-484D-BA61-78D9311864D0)

Related issue/s

How to test

Dev-ops ⚠️

When releasing this to any deployment, do the following:

  • Go to Redis-Commander
  • Open the redis console on DB number 6
  • Run below script (which removes all the keys in that database)
EVAL "for _,k in ipairs(redis.call('KEYS','*')) do redis.call('DEL',k) end" 0

@GitHK GitHK changed the title 🐛 Unified the redis_namespace for LRT 🐛 Unified the redis_namespace for LRT ⚠️ Oct 3, 2025
@GitHK GitHK self-assigned this Oct 3, 2025
@GitHK GitHK added this to the Cheops milestone Oct 3, 2025
@codecov
Copy link

codecov bot commented Oct 3, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.54%. Comparing base (043485c) to head (1595470).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #8450      +/-   ##
==========================================
+ Coverage   87.44%   87.54%   +0.09%     
==========================================
  Files        1913     1555     -358     
  Lines       74968    64610   -10358     
  Branches     1333      678     -655     
==========================================
- Hits        65556    56563    -8993     
+ Misses       9013     7809    -1204     
+ Partials      399      238     -161
Flag Coverage Δ
integrationtests 64.11% <100.00%> (-0.02%) ⬇️
unittests 85.98% <100.00%> (-0.11%) ⬇️
Components Coverage Δ
pkg_aws_library ∅ <ø> (∅)
pkg_celery_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library 70.96% <100.00%> (+0.01%) ⬆️
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 84.89% <ø> (ø)
agent 93.53% <ø> (ø)
api_server 91.78% <ø> (ø)
autoscaling 95.71% <ø> (ø)
catalog 92.36% <ø> (ø)
clusters_keeper 99.13% <ø> (ø)
dask_sidecar 92.35% <ø> (ø)
datcore_adapter 97.94% <ø> (ø)
director 75.81% <ø> (ø)
director_v2 90.89% <100.00%> (-0.02%) ⬇️
dynamic_scheduler 96.71% <ø> (∅)
dynamic_sidecar 90.43% <ø> (ø)
efs_guardian 89.74% <ø> (ø)
invitations 91.41% <ø> (ø)
payments 92.71% <ø> (ø)
resource_usage_tracker 92.15% <ø> (-0.06%) ⬇️
storage 86.45% <ø> (-0.21%) ⬇️
webclient ∅ <ø> (∅)
webserver 87.63% <ø> (-0.04%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 043485c...1595470. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mergify
Copy link
Contributor

mergify bot commented Oct 3, 2025 •
edited
Loading

🧪 CI Insights

Here's what we observed from your CI run for 1595470.

✅ Passed Jobs With Interesting Signals

Pipeline Job Signal Health on master Retries 🔍 CI Insights 📄 Logs
CI integration-tests Base branch is healthy, but retries were needed. Could be early signs of flakiness 👀 Healthy 1 View View

@GitHK GitHK added bug buggy, it does not work as expected a:services-library issues on packages/service-libs labels Oct 3, 2025
@GitHK GitHK marked this pull request as ready for review October 3, 2025 13:40
YuryHrytsuk
YuryHrytsuk approved these changes Oct 3, 2025
View reviewed changes
Copy link
Contributor

@YuryHrytsuk YuryHrytsuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@GitHK GitHK added the t:maintenance Some planned maintenance work label Oct 3, 2025
pcrespov
pcrespov approved these changes Oct 3, 2025
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx. Left some suggestions

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 6, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@GitHK GitHK merged commit dde3639 into ITISFoundation:master Oct 6, 2025
146 of 148 checks passed
@GitHK GitHK deleted the pr-osparc-bug-lrt-not-cleaning branch October 6, 2025 11:36
@GitHK GitHK changed the title 🐛 Unified the redis_namespace for LRT ⚠️ 🐛 Unified the redis_namespace for LRT ⚠️🚨 Oct 21, 2025
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Oct 28, 2025
Closed
22 tasks
@YuryHrytsuk YuryHrytsuk mentioned this pull request Oct 28, 2025
Closed
56 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@giancarloromeo giancarloromeo giancarloromeo approved these changes

@pcrespov pcrespov pcrespov approved these changes

@YuryHrytsuk YuryHrytsuk YuryHrytsuk approved these changes

@bisgaard-itis bisgaard-itis bisgaard-itis approved these changes

@sanderegg sanderegg Awaiting requested review from sanderegg sanderegg is a code owner

@matusdrobuliak66 matusdrobuliak66 Awaiting requested review from matusdrobuliak66

Assignees

@GitHK GitHK

Labels

a:services-library issues on packages/service-libs bug buggy, it does not work as expected t:maintenance Some planned maintenance work

Projects

None yet

Milestone

Cheops

Development

Successfully merging this pull request may close these issues.

5 participants

@GitHK @giancarloromeo @pcrespov @YuryHrytsuk @bisgaard-itis